-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NativeDB pruning #1746
Merged
Merged
NativeDB pruning #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73a9f44
to
761003d
Compare
eyusufatik
reviewed
Feb 3, 2025
Only enabled for test all flow
eyusufatik
reviewed
Feb 4, 2025
eyusufatik
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements pruning for old native DB records.
When starting at block #1, the version that gets created for all the keys that are stored into the accessory table are assigned 2 which means that the version is ahead of block number by one.
That being said, the current way of pruning is inefficient. Since we have to iterate all entries in the native DB table and compare the version of the key. Unfortunately, there is no way the pruner could figure out which keys specifically changed between two pruning cycles to be able to prune just those.
However, each time the number of entries in this table grows, the pruning process will decrease them significantly which means that the next cycle will need to iterate fewer items.
Linked Issues