fix: Safe handling of empty Jellyfish Merkle Tree initialization #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyusufatik
requested changes
Jan 30, 2025
crates/sovereign-sdk/module-system/sov-state/src/prover_storage.rs
Outdated
Show resolved
Hide resolved
eyusufatik
approved these changes
Jan 30, 2025
|
closing PR as bot activity |
I provided some help to your project, and youclosed my pr, ok that's no problem. But I just wonder why do you consider my activity as bot's? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the handling of empty Jellyfish Merkle Trees (JMT) in the prover storage implementation:
This change ensures safe operation with snapshots by properly validating tree state
and version numbers during initialization.
Resolves TODO: "Fix this before introducing snapshots!"