Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore commit/reveal monitoring chain on startup #1778

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

jfldde
Copy link
Contributor

@jfldde jfldde commented Jan 30, 2025

Description

  • Filter reveal utxos from listunspent. Re-build commit/reveal tx chain from utxos
  • This will always push txids pairs and fixes the odd number of tx issue.
  • This sheds potential cpfp/funding txs from listunspent to keep even commit/reveal pairs

Issues :

Fixes #1747

@jfldde jfldde requested a review from eyusufatik as a code owner January 30, 2025 22:37
@auto-assign auto-assign bot requested a review from ercecan January 30, 2025 22:37
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 77.4%. Comparing base (2147611) to head (923febf).
Report is 1 commits behind head on nightly.

Files with missing lines Patch % Lines
crates/bitcoin-da/src/monitoring.rs 0.0% 30 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/bitcoin-da/src/monitoring.rs 35.4% <0.0%> (-4.0%) ⬇️

... and 3 files with indirect coverage changes

@eyusufatik eyusufatik merged commit 62e7b35 into nightly Jan 31, 2025
14 of 15 checks passed
@eyusufatik eyusufatik deleted the fix-monitoring-restoration branch January 31, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix OddNumberOfTxs monitoring failure on sequencer restart
2 participants