Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add txs_commitment to Da Header #319

Merged
merged 8 commits into from
Mar 29, 2024
Merged

Add txs_commitment to Da Header #319

merged 8 commits into from
Mar 29, 2024

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Mar 28, 2024 •
edited
Loading

Description

#229 introduced a system contract which requires a merkle root to be passed to L1BlockHashList::setBlockInfo. This PR introduces a txs_commitment in BlockHeader to be passed to Evm::begin_soft_confirmation_hook.

Linked Issues

Testing

make test

@kpp kpp added the T - enhancement New feature or request label Mar 28, 2024
@kpp kpp requested a review from eyusufatik March 28, 2024 18:10
eyusufatik
eyusufatik requested changes Mar 29, 2024
View reviewed changes
Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two main takeaways:

  • Name it something like transaction_commitment
  • For bitcoin da transaction commitment should be the seg-wit one not the original merkle root. service.rs and verifier.rs has examples

crates/sovereign-sdk/rollup-interface/src/state_machine/da.rs Outdated Show resolved Hide resolved
crates/sovereign-sdk/module-system/sov-modules-stf-blueprint/src/lib.rs Outdated Show resolved Hide resolved
crates/sovereign-sdk/adapters/celestia/src/celestia.rs Outdated Show resolved Hide resolved
crates/sovereign-sdk/adapters/avail/src/spec/header.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/spec/header.rs Outdated Show resolved Hide resolved
crates/evm/src/tests/hooks_tests.rs Show resolved Hide resolved
crates/evm/src/hooks.rs Outdated Show resolved Hide resolved
@kpp kpp marked this pull request as draft March 29, 2024 09:01
@kpp kpp changed the title Add merkle_root to Da Header Add txs_commitment to Da Header Mar 29, 2024
@kpp kpp marked this pull request as ready for review March 29, 2024 11:26
@kpp kpp requested a review from eyusufatik March 29, 2024 11:26
eyusufatik
eyusufatik previously approved these changes Mar 29, 2024
View reviewed changes
@eyusufatik eyusufatik mentioned this pull request Mar 29, 2024
Closed
@kpp kpp merged commit 7fe2f9e into nightly Mar 29, 2024
4 checks passed
@kpp kpp deleted the kpp/header_merkle_root branch March 29, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyusufatik eyusufatik eyusufatik approved these changes

Assignees

@kpp kpp

Labels
T - enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpp @eyusufatik