-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement SDS admonitions for docs site #1401
Conversation
Also, could we change the styling on the example page from blue callouts to the accordion styling used in the FAQ page? With that change, please also update the color of the callouts on the napari page to the blue that is from the current examples callouts. |
@dgmccart to clarify - we want to use the blue from the theme, instead of the blue from sds? Current blue (from sphinx-immaterial theme): SDS blue (recommended by Kevin, see https://sds.czi.design/009eaf17b/p/72e266-callouts) |
Good catch - use the SDS blue please. |
bebb51c
to
6c9b74b
Compare
I've updated the PR with the requested changes. Maybe I am missing something but I didn't find any details on how to use admonitions for dark mode in SDS - so I kept them as-is. Let me know if this should be changed. I don't know if I like them, to be honest 😅 Some examples: Full Preview: https://melissawm.github.io/cryoet-data-portal/cryoet_data_portal_docsite_examples.html#examples |
@kev-zunshiwang could you do a quick review of the dark mode implementation to see if it is acceptable? |
Hey Melissa, some spec feedback for the callout component below:
|
Some feedback for the accordion component:
|
Dark mode for callout component: You can reach out to #sci-design-system-support and Timmy or Masoud will hop in for help! |
@melissawm Let me know if you need help reaching out to them. |
Hi all - I did not have the correct link to SDS. Looking at the links in the channel linked above I found the correct repo for SDS and I can see the dark mode recommendations: https://chanzuckerberg.github.io/sci-components/?path=/story/components-callout--default&globals=theme:dark Thanks!! |
4c48eb5
to
740c783
Compare
740c783
to
afae8e8
Compare
LGTM! |
Closes #765
Implements callouts according to SDS
PREVIEW: https://melissawm.github.io/cryoet-data-portal/cryoet_data_portal_docsite_examples.html#examples
See also https://melissawm.github.io/cryoet-data-portal/cryoet_data_portal_docsite_napari.html#using-napari