[CZID-8914] Mark empty SPAdes output as failed assembly #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzlim08
approved these changes
Nov 21, 2023
scripts/release.sh
Outdated
| @@ -30,7 +30,7 @@ fi | |||
|
|
|||
| # Fix until we can update this script to follow semantic versioning | |||
| if [[ $WORKFLOW_NAME == amr ]]; then | |||
| TAG="amr-v1.3.1" | |||
| TAG="amr-v1.3.2-beta.1" | |||
There was a problem hiding this comment.
To be honest, I think we can remove this code. If we merge this into main and release it, it should go to amr-v1.3.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the workflow failed to handle cases in which samples ran through SPAdes assembly without error but did not have any contigs. The SPAdes output was not marked as ";ASSEMBLY FAILED", causing an error further along in the workflow.