fix: Alert user when image field is not specified in docker-compose f…

…ile (#2795)
chanzuckerberg · Nov 28, 2023 · 1e93d7a · 1e93d7a
1 parent 4c0d409
commit 1e93d7a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/cli/COVERAGE b/cli/COVERAGE
@@ -1 +1 @@
-22.10
+22.14
diff --git a/cli/pkg/artifact_builder/COVERAGE b/cli/pkg/artifact_builder/COVERAGE
@@ -1 +1 @@
-53.5
+53.6
diff --git a/cli/pkg/artifact_builder/artifact_builder.go b/cli/pkg/artifact_builder/artifact_builder.go
@@ -354,6 +354,12 @@ func (ab ArtifactBuilder) push(ctx context.Context, tags []string, servicesImage
 		}
 
 		image := servicesImage[serviceName]
+		parts := strings.Split(image, ":")
+
+		if len(parts) != 2 || len(strings.TrimSpace(parts[0])) == 0 {
+			return errors.Errorf("invalid image reference for service '%s': '%s'. Make sure docker-compose file has the image field specified for this service.", serviceName, image)
+		}
+
 		for _, currentTag := range tags {
 			// re-tag image
 			cmd := exec.CommandContext(ctx, "docker", "tag", image, fmt.Sprintf("%s:%s", registry.URL, currentTag))