-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NavigationFooter): implement NavigationFooter component #886
base: main
Are you sure you want to change the base?
Conversation
Thanks Jeremy! Most feedback are similar to the header feedback, except the image slot one is new. Desktop Feedback
Tag
Image slot
|
Mobile Feedback
|
fdde74b
to
c9acd23
Compare
fd7f35f
to
96fbc01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks so much for adding this, @codemonkey800 🎉 !! Right in time for VCP to use 🙏 🙏 🙏
Not a blocker, but IIRC many SDS components are wrapped in forwardRef()
not sure if it makes sense to do it here too as a followup PR 😄
Thanks again!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @codemonkey800!! Added a few comments of things to adjust, but they're mostly small tweaks so hopefully should be straight forward. Feel free to reach out with any questions though!
a305294
to
2c8358b
Compare
Summary
Github issue: #817
Implements NavigationFooter component for desktop and mobile
Checklist
defaultTheme.ts
used wherever possible