Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scipy sparse bug #1166

Closed
wants to merge 3 commits into from
Closed

fix: scipy sparse bug #1166

wants to merge 3 commits into from

Conversation

Bento007
Copy link
Contributor

@Bento007 Bento007 commented Jan 7, 2025

Reason for Change

Changes

  • pin scipy to scipy<1.15

Testing

  • unit tests

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (093e4ae) to head (61876b9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1166   +/-   ##
=======================================
  Coverage   90.47%   90.47%           
=======================================
  Files          18       18           
  Lines        2069     2069           
=======================================
  Hits         1872     1872           
  Misses        197      197           
Components Coverage Δ
cellxgene_schema_cli 91.77% <0.00%> (ø)
migration_assistant 91.26% <0.00%> (ø)
schema_bump_dry_run_genes 79.80% <0.00%> (ø)
schema_bump_dry_run_ontologies 99.53% <0.00%> (ø)

Copy link
Contributor

@nayib-jose-gloria nayib-jose-gloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you (correctly) pointed out previously, the long-tail of the 5.3 updates in main means this is going to be annoying to release as a patch.

do you think its worth reverting main to 5.2.1 and creating a feature branch now to re-apply all the 5.3 commits since then to a feature branch? cc: @joyceyan

@Bento007
Copy link
Contributor Author

Bento007 commented Jan 8, 2025

@nayib-jose-gloria, why 5.2.1? Also we can do a 5.2.3 release with the patch and merge that back into main. That should retain all of the 5.3 changes and the 5.2.3 patch.

@joyceyan
Copy link
Contributor

joyceyan commented Jan 8, 2025

do you think its worth reverting main to 5.2.1 and creating a feature branch now to re-apply all the 5.3 commits since then to a feature branch?

@nayib-jose-gloria do you mean reverting main to 5.2.2? i think effort wise the two choices (revert main to 5.2.2 and release this change as 5.2.3 vs release this change as a 5.2.3 patch) seem fairly equivalent to me. i would probably slightly prefer reverting main to 5.2.2 and moving the 5.3 commits to a feature branch since we don't have a timeline set for actually releasing 5.3 yet

@Bento007
Copy link
Contributor Author

These changes were made in 5.2.3

@Bento007 Bento007 closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants