-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mypy to the scripts/ module #671
Conversation
Codecov Report
@@ Coverage Diff @@
## main #671 +/- ##
=======================================
Coverage 84.73% 84.73%
=======================================
Files 19 19
Lines 1815 1815
=======================================
Hits 1538 1538
Misses 277 277
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3ca582f
to
a18c5da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments for your review before merging, but overall looks reasonable!
Also, @Bento007 might be another worthwhile reviewer on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one comment suggestion.
add mypy to the scripts/ module
2459fa3
to
80fa2d3
Compare
Reason for Change
Changes
pyproject.toml
make mypy
, which runsmypy --config-file pyproject.toml
run_mypy_and_annotate.py
script to the root directory of the project, which runs the following command:mypy --config-file pyproject.toml
and annotates offending lines with# type: ignore
Testing
make mypy
can run with no issuesNotes for Reviewer