Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the sync flag's type consistent in the Socket module #26485

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

e-kayrakli
Copy link
Contributor

The Socket module uses a sync variable in some of its functions to wait for some events. This sync variable is passed via c_ptrs to a callback function. However there are inconsistencies in the types used:

  • There are 4 places where this happens: 3 of them uses sync c_short, 1 uses sync int
  • The callback function assumes that the flag is sync int.

The callbacks seems to write a c_short into this sync variable. Therefore, I assume that c_short is a more correct choice. So, this PR makes the sync variable of c_short type and adjusts the callback.

Test:

  • local library/package/Socket

@e-kayrakli e-kayrakli requested a review from mppf January 7, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants