Make the sync flag's type consistent in the Socket module #26485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Socket module uses a sync variable in some of its functions to wait for some events. This sync variable is passed via
c_ptr
s to a callback function. However there are inconsistencies in the types used:sync c_short
, 1 usessync int
sync int
.The callbacks seems to write a
c_short
into this sync variable. Therefore, I assume thatc_short
is a more correct choice. So, this PR makes the sync variable ofc_short
type and adjusts the callback.Test:
library/package/Socket