Turn off Python sub-interpreter tests #26614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
lydia-duncan
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
I'm okay with this approach, but I do wonder if some type of sorting attempt would help alleviate the inconsistency, instead of silencing the tests. Still, this seems to be something you're actively working on generally, so I'm okay with turning it off for now as long as you're intending to get back to it soon (and will take steps to keep this from being swept under the rug if you don't get back to it in the next month or two)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns off Python sub-interpreter tests. These tests have wildly unpredictable output due to race conditions. This PR also adds a warning to the docs warning users about this.
The unpredictable behavior is caused by race conditions when creating/destroying sub-interpreters, see #26615.
This PR has a few other nit cleanups.
[Reviewed by @lydia-duncan]