Skip to content

Commit

Permalink
fix(ci): pin charmcraft to version 3.2.3
Browse files Browse the repository at this point in the history
Revert charmcraft to version 3.2.3 to get around caching issue. Also include some minor cosmetic changes such as license header updates and renaming jobs from Release -> Publish since that is the name of the workflow file.

Signed-off-by: Jason C. Nucciarone <[email protected]>
  • Loading branch information
NucciTheBoss committed Jan 29, 2025
1 parent 8a50471 commit 980c087
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 6 deletions.
11 changes: 9 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2024 Canonical Ltd.
# Copyright 2024-2025 Canonical Ltd.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -115,6 +115,13 @@ jobs:
uses: charmed-kubernetes/actions-operator@main
with:
provider: lxd
juju-channel: 3.4/stable
juju-channel: 3.6/stable
# TODO: https://github.com/canonical/charmcraft/issues/2125 -
# Remove pin to charmcraft 3.2.3 once `FileExistsError` is fixed
# when accessing the charmcraft build cache in parallel builds.
- name: Revert to charmcraft 3.2.3
run: |
sudo snap refresh charmcraft --revision=5858
sudo snap refresh charmcraft --hold
- name: Run tests
run: just repo integration
26 changes: 22 additions & 4 deletions .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE for licensing details.
# Copyright 2024-2025 Canonical Ltd.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

name: Release to latest/edge

Expand Down Expand Up @@ -43,13 +54,20 @@ jobs:
uses: canonical/[email protected]
with:
channel: 5.21/stable
- name: Release updated libraries to Charmhub
# TODO: https://github.com/canonical/charmcraft/issues/2125 -
# Remove pin to charmcraft 3.2.3 once `FileExistsError` is fixed
# when accessing the charmcraft build cache in parallel builds.
- name: Revert to charmcraft 3.2.3
run: |
sudo snap refresh charmcraft --revision=5858
sudo snap refresh charmcraft --hold
- name: Publish updated charm libraries to Charmhub
uses: canonical/charming-actions/[email protected]
with:
credentials: "${{ secrets.CHARMCRAFT_AUTH }}"
github-token: "${{ secrets.GITHUB_TOKEN }}"
charm-path: "./_build/${{ matrix.charm }}"
- name: Upload charm to Charmhub
- name: Publish charm to Charmhub
uses: canonical/charming-actions/[email protected]
with:
credentials: "${{ secrets.CHARMCRAFT_AUTH }}"
Expand Down

0 comments on commit 980c087

Please sign in to comment.