Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

chore: fix CI pipeline #20

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

jedel1043
Copy link
Contributor

Description

Fixes our CI so that we're testing PRs and pushes to main.
Fixes a bug with the charm where we weren't installing the slurm-wlm-basic-plugins package,
which is required by slurmrestd to run.

How was the code tested?

Locally in my Ubuntu Jammy development setup.

Checklist

  • I am the author of these changes, or I have the rights to submit them.
  • I have added the relevant changes to the README and/or documentation.
  • I have self reviewed my own code.
  • All requested changes and/or review comments have been resolved.

slurmrestd cannot run without this package installed, since it requires the libslurmfull.so file.
We don't really need to deploy against slurmd to check that slurmrestd works. This saves some CI time.
@jedel1043 jedel1043 force-pushed the fix-ci-pipeline branch 3 times, most recently from b54e843 to 4feebd8 Compare July 18, 2024 17:36
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one small clarification question, but I won't block merging the PR on it.

src/slurmrestd_ops.py Show resolved Hide resolved
@NucciTheBoss NucciTheBoss merged commit 9d0322b into charmed-hpc:main Jul 18, 2024
5 of 6 checks passed
@jedel1043 jedel1043 deleted the fix-ci-pipeline branch July 18, 2024 22:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants