Refactor reconciler #4
Open
+28
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
requested changes
Jan 30, 2025
Comment on lines
+29
to
+30
| custom_events: Optional[list[BoundEvent]] = None, | ||
| exit_status: StatusBase = BlockedStatus("Reconcile failed"), |
There was a problem hiding this comment.
Um, let's not swap the order here... also use List b/c py38 is special
Suggested change
| custom_events: Optional[list[BoundEvent]] = None, | |
| exit_status: StatusBase = BlockedStatus("Reconcile failed"), | |
| exit_status: StatusBase = BlockedStatus("Reconcile failed"), | |
| custom_events: Optional[List[BoundEvent]] = None, |
| ): | ||
| super().__init__(charm, "reconciler") |
There was a problem hiding this comment.
Um? i don't think ops will let you do this.
| self.charm = charm | ||
| self.reconcile_function = reconcile_function | ||
| self.stored.set_default(reconciled=False) |
There was a problem hiding this comment.
nah, i'm not ready to eliminate this state. We don't want to reconcile on EVERY hook. Update-status hook could run every second. We'd melt things into the ground constantly reconciling an already reconciled unit. There's no value with this
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class Reconciler(Object): | ||
| stored = StoredState() |
Comment on lines
-37
to
+55
| def reconcile(self, event): | ||
| if isinstance(event, UpdateStatusEvent) and self.stored.reconciled: | ||
| def reconcile(self: "Reconciler", event: EventBase) -> None: | ||
| try: | ||
| self.reconcile_function(event) | ||
| except ReconcileErrorWithStatus as e: | ||
| log.exception(f"reconcile failed: {e}") | ||
| self.charm.unit.status = e.status | ||
| return | ||
|
|
||
| self.stored.reconciled = False | ||
|
|
||
| with status.context(self.charm.unit, self.exit_status): | ||
| try: | ||
| self.reconcile_function(event) | ||
| self.stored.reconciled = True | ||
| except status.ReconcilerError: | ||
| log.exception("Caught ReconcilerError") | ||
| self.charm.unit.status = self.exit_status |
There was a problem hiding this comment.
Alright, i don't understand what's going on here. How are we getting away with not using the status.context anymore?
something isn't right here anymore and i'm not sure i see the imrpovement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
This PR simplifies this module and provides an interface that more closely resembles the Kubernetes controller semantics.