Switch async images to UBI

[tomgeorge]

Switch the alpine images to UBI, #10

Signed-off-by: Tom George [email protected]

[ibuziuk]

@tomgeorge could you please clarify how the PR was tested, also wondering it there are any issues with the following config / scripts after the UBI switch:

• https://github.com/che-incubator/workspace-data-sync/blob/master/dockerfiles/storage/sshd_config
• https://github.com/che-incubator/workspace-data-sync/tree/master/dockerfiles/agent/scripts
• https://github.com/che-incubator/workspace-data-sync/blob/master/dockerfiles/agent/cron/backup-cron-job

[ibuziuk]

probably the comment should be udpated

[benoitf]

AFAIK ubi and non-ubi are separated Dockerfiles

like Dockerfile with alpine and Dockerfile.rhel with ubi8 from

[ibuziuk]

@benoitf we do not plan to have non-ubi dockerfiles

[benoitf]

@ibuziuk why ? all images of che are not ubi based by default

[ibuziuk]

@benoitf I believe it is up to plugin / component developers to decide ;-)
image puller is UBI based by default, eventhough we have centos image, it is not used anywhere (with the recent centos stream announcement it is doomed to be deprecated in general). In order to lower the support burden, I would opt for ubi / ubi-minimal only for async-storage

[benoitf]

@ibuziuk

quay.io/eclipse/che-workspace-data-sync-storage   latest               7b0123559264   48 seconds ago       251MB
quay.io/eclipse/che-sidecar-workspace-data-sync   latest               565bce0cc468   About a minute ago   248MB
quay.io/eclipse/che-workspace-data-sync-storage   alpine               66abd0279cd9   3 minutes ago        12.3MB
quay.io/eclipse/che-sidecar-workspace-data-sync   alpine               b615ce49c122   3 minutes ago        39.1MB

it's a diff of more than 200MB per image for nothing
Images should be as small as possible for upstream che.

[ibuziuk]

@tomgeorge maybe it is possible to use - https://catalog.redhat.com/software/containers/ubi8/ubi-minimal/5c359a62bed8bd75a2c3fba8
@benoitf we can provide UBI & non-UBI versions. However, managing extra images creates an additional support burden for the teams and I believe we need to find an alternative to alpine that would be also suitable for product

[tomgeorge]

I have working ubi-minimal images but they are still pretty big:

quay.io/eclipse/che-sidecar-workspace-data-sync                                    latest         155288cd5b71   11 minutes ago      173MB
quay.io/eclipse/che-workspace-data-sync-storage                                    latest         4f1236fc9180   About an hour ago   163MB

[ibuziuk]

@tomgeorge based on the discussion with @benoitf let's have separate ubi and alpine images for the product and project respectively

[tomgeorge]

Added the alpine Dockerfiles back and named the ubi dockerfiles ubi.Dockerfile

ubi images are not replacing alpine one

[ibuziuk]

@benoitf could you please review?

[benoitf]

Please add a comment line

# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi8-minimal

Helping to see new images

Also, please stick to a given version like FROM registry.access.redhat.com/ubi8-minimal:8.3-230

[benoitf]

I think it's a copy/error typo of the header (Dockerfile is not a bash script)

[benoitf]

please follow convention of && at end of lines or beginning of lines

[tomgeorge]

I do have && at beginning of lines, it's the same as dockerfiles/agent/Dockerfile?

[benoitf]

Ok maybe I read the only wrong line

&& mkdir  /var/run/sshd && \

[benoitf]

same remarks than for the other Dockerfile (bash header, comment to see new updates and stick to a fine grain version tag)