Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add New Fields and Update Tests for Payment Processing #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add New Fields and Update Tests for Payment Processing #147

wants to merge 1 commit into from

Conversation

armando-rodriguez-cko
Copy link
Contributor

feat: Add New Fields and Update Tests for Payment Processing

Description:

This PR introduces enhancements to the payment processing functionality by adding new fields to the RequestNetworkTokenSource struct and updating related test cases for better coverage and functionality. The changes also include minor adjustments to test descriptions and assertions.

Key Changes:

  1. New Fields in RequestNetworkTokenSource:

    • Added storeForFutureUse to support preferences for future token storage.
    • Adjusted field order for consistency and readability.

  2. Test Enhancements:

    • HostedPaymentsTest:
      • Updated DisplayName field to provide more descriptive test data.
    • InstrumentsTest:
      • Marked TestShouldGetBankAccountFields with t.Skip("unavailable") to manage unavailable scenarios gracefully.
    • PaymentsRequestApmTest:
      • Simplified assertions by removing redundant checks for payee_not_onboarded error.

  3. Additional Updates:

    • Added panTypeProcessed and ckoNetworkTokenAvailable fields to payment processing metadata for improved clarity.

Impact:

  • Functionality:
    • Enhanced flexibility in handling network token source configurations.
    • Improved clarity and metadata for processing payments.
  • Testing:
    • Strengthened test coverage ensures reliability and better handling of edge cases.

Testing:

  • Validated new fields in RequestNetworkTokenSource.
  • Confirmed updates to test cases and ensured expected behavior.
  • Skipped specific tests where functionality is currently unavailable.

Notes:

  • These changes improve overall functionality and maintainability of the payment processing module.
  • Future PRs may focus on additional edge case handling and enhanced test scenarios.

@armando-rodriguez-cko
feat: add new fields and update tests for payment processing
03c54ee 
- Added `storeForFutureUse` to `requestNetworkTokenSource`.
- Introduced `panTypeProcessed` and `ckoNetworkTokenAvailable` to `Processing` struct.
- Updated test `getHostedPaymentRequest` to refine `DisplayName` format.
- Marked `TestShouldGetBankAccountFields` as skipped with a reason.
- Removed error assertion for unprocessable entity in `TestRequestPaymentsAPM`.
@armando-rodriguez-cko armando-rodriguez-cko requested a review from a team January 24, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavo-porto-cko gustavo-porto-cko gustavo-porto-cko approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armando-rodriguez-cko @gustavo-porto-cko