Add WithCurrencyAccountId to QueryFilter struct #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsmAbd
force-pushed
the
ia/101323/balance_request
branch
from
0f67632 to
ab9ec14
Compare
armando-rodriguez-cko
approved these changes
Nov 14, 2023
|
Thank you @IsmAbd! |
|
@armando-rodriguez-cko No worries! Are you able to create a new release which includes that change? |
|
Tomorrow will be lunch a new release with your changes. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per documentation, the
/balancesendpoint currently supports following query parameters:Query (e.g. "query=currency:USD") which allows filtering accounts by a provided currency.
WithCurrencyAccountId (e.g. "withCurrencyAccountId=true") which can be used to include the account id in the response.
This PR adds
WithCurrencyAccountIdfield to the QueryFilter struct to allow using WithCurrencyAccountId in the Blances request.