Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small improvement #3

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

A small improvement #3

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6b0bd94
disable spell check on input
JonesJugHead Nov 17, 2024
a4822de
add css
JonesJugHead Nov 17, 2024
2540257
add preview function and delete button
JonesJugHead Nov 17, 2024
4236a30
Remove comment & replace " by '
JonesJugHead Nov 19, 2024
0027fff
Update script.js
JonesJugHead Nov 19, 2024
7c47421
Merge branch 'main' into feature/saved-lore-preview-and-delete
JonesJugHead Dec 22, 2024
ecfe56e
Fix saved lore pre
JonesJugHead Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions lore-generator/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ document.addEventListener('DOMContentLoaded', function () {
classes.push('underline');
if (formatting.strikethrough)
classes.push('strikethrough');
const classAttr = classes.length ? ` class="${classes.join(' ')}"` : '';
return `<span style="${style}"${classAttr}>${escapeHtml(content)}</span>`;
const classAttr = classes.length ? ` class='${classes.join(' ')}'` : '';
return `<span style='${style}'${classAttr}>${escapeHtml(content)}</span>`;
}

return result;
Expand All @@ -184,7 +184,7 @@ document.addEventListener('DOMContentLoaded', function () {
return '';

let code = 'set lore of {_item} to ';
const formattedLines = loreLines.map(line => `"${line.replace(/"/g, '""')}"`);
const formattedLines = loreLines.map(line => `'${line.replace(/'/g, '''')}'`);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually changing the functionality

if (formattedLines.length === 1) {
code += formattedLines[0];
} else if (formattedLines.length === 2) {
Expand Down Expand Up @@ -228,7 +228,6 @@ document.addEventListener('DOMContentLoaded', function () {
const loreDiv = document.createElement('div');
loreDiv.classList.add('saved-lore');

// Add the Skript code
const codePre = document.createElement('pre');
codePre.textContent = lore.code;
loreDiv.appendChild(codePre);
Expand All @@ -251,20 +250,18 @@ document.addEventListener('DOMContentLoaded', function () {
navigator.clipboard.writeText(lore.code).then(showCopyNotification);
});

const deleteButton = document.createElement("button");
deleteButton.textContent = "Delete";
deleteButton.addEventListener("click", function () {
const deleteButton = document.createElement('button');
deleteButton.textContent = 'Delete';
deleteButton.addEventListener('click', function () {
savedLores = savedLores.filter((l) => l.code !== lore.code);
saveLoresToLocalStorage();
updateSavedLores();
});

// Create a container for the preview and code
const container = document.createElement("div");
container.classList.add("lore-container");
const container = document.createElement('div');
container.classList.add('lore-container');
loreDiv.appendChild(container);

// Add the preview
createLorePreview(container, lore.text);

buttonGroup.appendChild(copyButton);
Expand All @@ -288,14 +285,14 @@ document.addEventListener('DOMContentLoaded', function () {
}

function createLorePreview(parent, text) {
const previewContainer = document.createElement("div");
previewContainer.classList.add("preview-tooltip");
const preview = document.createElement("div");
const previewContainer = document.createElement('div');
previewContainer.classList.add('preview-tooltip');
const preview = document.createElement('div');
previewContainer.appendChild(preview);
const lines = text.split("\n");
const lines = text.split('\n');
lines.forEach((line) => {
const lineElement = document.createElement("div");
lineElement.classList.add("preview-line");
const lineElement = document.createElement('div');
lineElement.classList.add('preview-line');
lineElement.innerHTML = parseSkriptFormatting(line);
preview.appendChild(lineElement);
});
Expand Down