feat: improve 1D line broadening filter #8029
jobo322nodejs.yml
on: pull_request
nodejs
/
prepare
16s
stylelint
42s
nodejs
/
lint-eslint
5m 17s
nodejs
/
lint-prettier
35s
nodejs
/
lint-check-types
4m 2s
Matrix: nodejs / test
Annotations
17 errors and 10 warnings
|
nodejs / lint-check-types:
src/component/2d/1d-tracer/phase-correction-traces/SpectrumPhaseTrace.tsx#L146
Argument of type 'Spectrum1D' is not assignable to parameter of type 'Entry1D'.
|
|
nodejs / lint-check-types:
src/component/header/SimpleApodizationOptionsPanel.tsx#L40
Type '"lineBroadening"' is not assignable to type '"options" | "livePreview" | "options.gaussian" | "options.exponential" | "options.lorentzToGauss" | "options.sineBell" | "options.sineSquare" | "options.traf" | "options.modifiedGaussian" | ... 104 more ... | "options.modifiedGaussian.shape.options.dwellTime"'.
|
|
nodejs / lint-check-types:
src/component/modal/editRange/forms/components/signal-tabs/SignalPeaksTable.tsx#L52
Argument of type 'Spectrum1D' is not assignable to parameter of type 'Entry1D'.
|
|
nodejs / lint-check-types:
src/component/modal/setting/settings-tabs/DatabasesTabContent.tsx#L40
Type instantiation is excessively deep and possibly infinite.
|
|
nodejs / lint-check-types:
src/component/panels/databasePanel/DatabasePanel.tsx#L517
Argument of type 'Spectrum1D' is not assignable to parameter of type 'Entry1D'.
|
|
nodejs / lint-check-types:
src/component/panels/filtersPanel/Filters/ApodizationOptionsPanel.tsx#L91
Type '"lineBroadening"' is not assignable to type '"options" | "livePreview" | "options.gaussian" | "options.exponential" | "options.lorentzToGauss" | "options.sineBell" | "options.sineSquare" | "options.traf" | "options.modifiedGaussian" | ... 104 more ... | "options.modifiedGaussian.shape.options.dwellTime"'.
|
|
nodejs / lint-check-types:
src/component/panels/filtersPanel/Filters/ApodizationOptionsPanel.tsx#L107
Type '"gaussBroadening"' is not assignable to type '"options" | "livePreview" | "options.gaussian" | "options.exponential" | "options.lorentzToGauss" | "options.sineBell" | "options.sineSquare" | "options.traf" | "options.modifiedGaussian" | ... 104 more ... | "options.modifiedGaussian.shape.options.dwellTime"'.
|
|
nodejs / lint-check-types:
src/component/panels/filtersPanel/Filters/ApodizationOptionsPanel.tsx#L122
Type '"lineBroadeningCenter"' is not assignable to type '"options" | "livePreview" | "options.gaussian" | "options.exponential" | "options.lorentzToGauss" | "options.sineBell" | "options.sineSquare" | "options.traf" | "options.modifiedGaussian" | ... 104 more ... | "options.modifiedGaussian.shape.options.dwellTime"'.
|
|
nodejs / lint-check-types:
src/component/panels/filtersPanel/Filters/FiltersSectionsPanel.tsx#L316
Type '{ filters: Filter[]; spectraCounter: number; activeFilterID: string | null; }' is not assignable to type 'FiltersInnerProps'.
|
|
nodejs / lint-check-types:
src/component/panels/filtersPanel/Filters/index.tsx#L1
'ButtonProps' is a type and must be imported using a type-only import when 'verbatimModuleSyntax' is enabled.
|
|
nodejs / lint-eslint:
src/component/header/SimpleApodizationOptionsPanel.tsx#L14
Expected 1 empty line after import statement not followed by another import
|
|
nodejs / lint-eslint:
src/component/panels/filtersPanel/Filters/FiltersSectionsPanel.tsx#L7
Prefer using a top-level type-only import instead of inline type specifiers
|
|
nodejs / lint-eslint:
src/component/panels/filtersPanel/Filters/FiltersSectionsPanel.tsx#L8
Prefer using a top-level type-only import instead of inline type specifiers
|
|
nodejs / lint-eslint:
src/component/panels/filtersPanel/Filters/index.tsx#L1
All imports in the declaration are only used as types. Use `import type`
|
|
nodejs / lint-eslint:
src/component/reducer/Reducer.ts#L8
'/home/runner/work/nmrium/nmrium/node_modules/nmr-processing/nmr-processing.mjs' imported multiple times
|
|
nodejs / lint-eslint:
src/component/reducer/Reducer.ts#L11
'/home/runner/work/nmrium/nmrium/node_modules/nmr-processing/nmr-processing.mjs' imported multiple times
|
|
nodejs / lint-eslint
Process completed with exit code 1.
|
|
nodejs / lint-eslint:
src/component/assignment/index.tsx#L31
Unexpected 'todo' comment: 'TODO: Fix this type error. It's been...'
|
|
nodejs / lint-eslint:
src/component/elements/Alert.tsx#L139
Do not use Array index in keys
|
|
nodejs / lint-eslint:
src/component/elements/Button.tsx#L1
Unexpected 'todo' comment: 'TODO resolve the eslint rules'
|
|
nodejs / lint-eslint:
src/component/elements/InputRange.tsx#L39
Unexpected 'todo' comment: 'TODO: remove this hacky ref usage.'
|
|
nodejs / lint-eslint:
src/component/elements/NumberInput2Controller.tsx#L19
Capture group '(\.\d+)' should be converted to a named or non-capturing group
|
|
nodejs / lint-eslint:
src/component/header/SimpleApodizationOptionsPanel.tsx#L14
`nmr-processing` type import should occur before import of `react`
|
|
nodejs / lint-eslint:
src/component/header/SimpleBaseLineCorrectionOptionsPanel.tsx#L20
`nmr-processing` type import should occur before import of `react`
|
|
nodejs / lint-eslint:
src/component/modal/MultipletAnalysisModal.tsx#L175
Unexpected 'todo' comment: 'TODO: handle error'
|
|
nodejs / lint-eslint:
src/component/panels/RangesPanel/hooks/useMapRanges.ts#L9
Unexpected 'todo' comment: 'TODO need to refactor the ranges table'
|
|
nodejs / lint-eslint:
src/component/panels/SummaryPanel/utilities/Utilities.ts#L125
Unexpected 'todo' comment: 'TODO: handle default?'
|