-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart multiplet analysis #2571
Comments
I think the limitation in the number of points is due the optimization of shape parameters. |
what is the status of this issue, can you check this with Luc ? |
When we have too many points we can not apply https://github.com/cheminfo/multiplet-analysis but we can still use the normal method. This is not related to optimization of shape parameters I think. |
There is a PR migrating from multiplet-analysis to normal range picking. so it could be closed at the moment to merge this PR |
when doing manual range picking the number of points may be to big and this prevents the smart multiplet analysis.
Could we in this case just have a fallback to the non smart multiplet analysis like we do when we analyse globally the spectrum ?
@jobo322 I think you could help Hamed to implement this fix or tell me if there are some issues.
The text was updated successfully, but these errors were encountered: