Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add peaks in manual range picking #2668

Merged
merged 11 commits into from
Nov 24, 2023

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Sep 13, 2023

do not use multilplet-analysis in

@jobo322 jobo322 linked an issue Sep 13, 2023 that may be closed by this pull request
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 13, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ba7627a
Status: ✅  Deploy successful!
Preview URL: https://2cd02df6.nmrium.pages.dev
Branch Preview URL: https://2665-manual-range-picking-wo.nmrium.pages.dev

View logs

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (72447eb) 53.57% compared to head (ba7627a) 52.96%.

Files Patch % Lines
src/data/data1d/Spectrum1D/ranges/addRange.ts 3.84% 25 Missing ⚠️
src/data/data1d/Spectrum1D/ranges/changeRange.ts 26.92% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2668      +/-   ##
==========================================
- Coverage   53.57%   52.96%   -0.61%     
==========================================
  Files          51       51              
  Lines        2492     2426      -66     
  Branches       88       83       -5     
==========================================
- Hits         1335     1285      -50     
+ Misses       1156     1140      -16     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jobo322 jobo322 linked an issue Sep 18, 2023 that may be closed by this pull request
@jobo322 jobo322 force-pushed the 2665-manual-range-picking-would-not-calculate-peaks branch from 4629022 to 3d32ad1 Compare October 6, 2023 03:46
@jobo322 jobo322 force-pushed the 2665-manual-range-picking-would-not-calculate-peaks branch from 13f4ba2 to f2cb41a Compare November 7, 2023 16:09
@jobo322 jobo322 force-pushed the 2665-manual-range-picking-would-not-calculate-peaks branch from b2c3d5b to 3884893 Compare November 24, 2023 09:24
@jobo322 jobo322 force-pushed the 2665-manual-range-picking-would-not-calculate-peaks branch 2 times, most recently from dba188b to 9051c0c Compare November 24, 2023 09:41
@jobo322 jobo322 merged commit 50de770 into main Nov 24, 2023
11 of 13 checks passed
@jobo322 jobo322 deleted the 2665-manual-range-picking-would-not-calculate-peaks branch November 24, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual range picking would not calculate peaks Smart multiplet analysis
2 participants