Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link JCAMP files are not loading #2757

Closed
hamed-musallam opened this issue Nov 21, 2023 · 1 comment · Fixed by #2761
Closed

link JCAMP files are not loading #2757

hamed-musallam opened this issue Nov 21, 2023 · 1 comment · Fixed by #2761
Assignees
@jobo322
Labels
bug Something isn't working

Comments

@hamed-musallam
Copy link
Member

hamed-musallam commented Nov 21, 2023 •
edited
Loading

We identified an additional issue in the JCAMP parser, specifically, the proton and carbon JCAMP files are not loading

https://s3.uni-jena.de/nmrxiv/production/archive/a9d8c2a7-fc95-4eb6-84dd-107548aa0c48/12c_HEE296.zip

image
@hamed-musallam hamed-musallam added the bug Something isn't working label Nov 21, 2023
@hamed-musallam hamed-musallam changed the title @jobo322 link JCAMP files are not loading Nov 21, 2023
@lpatiny
Copy link
Member

lpatiny commented Nov 21, 2023

The JCAMP-DX contains many spectra and it is normal LINK is not loaded.

However on the page: https://my.cheminfo.org/?dataURL=https%3A%2F%2Fmyviews.cheminfo.org%2Fdb%2Fvisualizer%2Fentry%2F7d3d52c930d0c4f381df1524593b3af3%2Fdata.json&viewURL=https%3A%2F%2Fmyviews.cheminfo.org%2Fdb%2Fvisualizer%2Fentry%2F7d3d52c930d0c4f381df1524593b3af3%2Fview.json

I can see a NMR spectrum

image

So it seems that the parser works correctly (but the view could contain an old version).

@jobo322 jobo322 linked a pull request Nov 22, 2023 that will close this issue
fix: jcamp tree filtering n wrong scale on F1 #2761
Merged
@github-project-automation github-project-automation bot moved this from 🔴 Todo to 🟢 Done in NMR and Cheminfo projects organisation Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jobo322 jobo322

Labels
bug Something isn't working
Projects
NMR and Cheminfo projects organisation
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: jcamp tree filtering n wrong scale on F1 cheminfo/nmrium
3 participants
@lpatiny @jobo322 @hamed-musallam