Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jcamp tree filtering n wrong scale on F1 #2761

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Nov 22, 2023

Also with version 0.23.6 of nmr-load-save, the molfile could be generated from jcamp-cs data, thanks to using the new feature parseJcampCSin jcampconverter

This was linked to issues Nov 22, 2023
Copy link

cloudflare-workers-and-pages bot commented Nov 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4fc067d
Status: ✅  Deploy successful!
Preview URL: https://c9a6d683.nmrium.pages.dev
Branch Preview URL: https://2756-wrong-2d-y-domain-and-s.nmrium.pages.dev

View logs

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db978d9) 53.57% compared to head (4329ca7) 53.57%.

❗ Current head 4329ca7 differs from pull request most recent head 4fc067d. Consider uploading reports for the commit 4fc067d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2761   +/-   ##
=======================================
  Coverage   53.57%   53.57%           
=======================================
  Files          51       51           
  Lines        2492     2492           
  Branches       88       88           
=======================================
  Hits         1335     1335           
  Misses       1156     1156           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jobo322 jobo322 linked an issue Nov 23, 2023 that may be closed by this pull request
@jobo322 jobo322 merged commit 72447eb into main Nov 24, 2023
11 checks passed
@jobo322 jobo322 deleted the 2756-wrong-2d-y-domain-and-scale branch November 24, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong spectrum object link JCAMP files are not loading Wrong 2d y domain and scale
2 participants