Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong spectrum object #2759

Closed
hamed-musallam opened this issue Nov 21, 2023 · 2 comments · Fixed by #2761
Closed

Wrong spectrum object #2759

hamed-musallam opened this issue Nov 21, 2023 · 2 comments · Fixed by #2761
Labels
bug Something isn't working

Comments

@hamed-musallam
Copy link
Member

hamed-musallam commented Nov 21, 2023 •
edited
Loading

The spectrum that contains an error, it returns with logger,keepSource objects which are supposed not to be there, and because of those objects we can not serialize the state object
Screenshot 2023-11-21 at 22 17 57
@hamed-musallam
Copy link
Member Author

it seems this happens just in the spectrum that has any level of logger error
Screenshot 2023-11-21 at 22 27 03

@hamed-musallam hamed-musallam added the bug Something isn't working label Nov 21, 2023
@hamed-musallam
Copy link
Member Author

hamed-musallam commented Nov 23, 2023 •
edited
Loading

the source of the issue is this line in the jeol read function, which we should remove it

https://github.com/cheminfo/nmr-load-save/blob/9478eac14081ae0973dd28f3cb1a85b3b34e621e/src/read/readJDF/readJDF.ts#L60

@jobo322 jobo322 linked a pull request Nov 23, 2023 that will close this issue
fix: jcamp tree filtering n wrong scale on F1 #2761
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: jcamp tree filtering n wrong scale on F1 cheminfo/nmrium
1 participant
@hamed-musallam