Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'any' type #2644

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Remove 'any' type #2644

merged 7 commits into from
Oct 23, 2023

Conversation

wadjih-bencheikh18
Copy link
Member

@wadjih-bencheikh18 wadjih-bencheikh18 commented Aug 23, 2023

Refs: #2375

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 23, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 30f349b
Status: ✅  Deploy successful!
Preview URL: https://48078b68.nmrium.pages.dev
Branch Preview URL: https://fix-types-remove-any.nmrium.pages.dev

View logs

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8cb92df) 53.14% compared to head (4276d66) 52.95%.

❗ Current head 4276d66 differs from pull request most recent head 30f349b. Consider uploading reports for the commit 30f349b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2644      +/-   ##
==========================================
- Coverage   53.14%   52.95%   -0.19%     
==========================================
  Files          51       50       -1     
  Lines        2497     2487      -10     
  Branches       90       88       -2     
==========================================
- Hits         1327     1317      -10     
  Misses       1169     1169              
  Partials        1        1              

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@targos
Copy link
Member

targos commented Oct 19, 2023

Can you fix the conflicts and move out of draft? The goal is not to remove all any in the same pull request.

@wadjih-bencheikh18 wadjih-bencheikh18 marked this pull request as ready for review October 19, 2023 22:16
@targos targos enabled auto-merge (squash) October 23, 2023 08:26
@targos targos merged commit 1b27799 into main Oct 23, 2023
@targos targos deleted the fix-types-remove-any branch October 23, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants