Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open the log history automatically if we have error or fatal #2758

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

hamed-musallam
Copy link
Member

close #2755

@hamed-musallam hamed-musallam linked an issue Nov 21, 2023 that may be closed by this pull request
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5bfa845
Status: ✅  Deploy successful!
Preview URL: https://37196713.nmrium.pages.dev
Branch Preview URL: https://change-logger-trigger-level.nmrium.pages.dev

View logs

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (4f0626b) 53.65% compared to head (5bfa845) 53.57%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/data/data2d/Spectrum2D/getSlice.ts 21.73% 54 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2758      +/-   ##
==========================================
- Coverage   53.65%   53.57%   -0.09%     
==========================================
  Files          51       51              
  Lines        2462     2492      +30     
  Branches       88       88              
==========================================
+ Hits         1321     1335      +14     
- Misses       1140     1156      +16     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamed-musallam hamed-musallam enabled auto-merge (rebase) November 21, 2023 18:22
@hamed-musallam hamed-musallam merged commit 5c7629e into main Nov 21, 2023
11 of 13 checks passed
@hamed-musallam hamed-musallam deleted the change-logger-trigger-level branch November 21, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

open logger window for error messages only
1 participant