Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing peaks when use multiplet-analysis #2814

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Dec 21, 2023

when data length is less than 4092 multiplet-analysis package is used

multiplet-analysis does not returns peaks, so an automatic peak picking is done on the ROI

when data length is less than 4092 multiplet-analysis package is used

multiplet-analysis does not returns peaks
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e17098b) 2.17% compared to head (38673a3) 2.19%.

Files Patch % Lines
...ctrum1D/ranges/detectSignalsByMultipletAnalysis.ts 95.55% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2814      +/-   ##
========================================
+ Coverage   2.17%   2.19%   +0.01%     
========================================
  Files        638     639       +1     
  Lines      62473   62469       -4     
  Branches     689     690       +1     
========================================
+ Hits        1361    1369       +8     
+ Misses     60524   60512      -12     
  Partials     588     588              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Jan 5, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 38673a3
Status: ✅  Deploy successful!
Preview URL: https://e2d2f417.nmrium.pages.dev
Branch Preview URL: https://add-peaks-manual-range-picki.nmrium.pages.dev

View logs

@jobo322 jobo322 merged commit 12d03b8 into main Jan 5, 2024
13 checks passed
@jobo322 jobo322 deleted the add-peaks-manual-range-picking-by-multiplet-analysis branch January 5, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant