Avoid adding .bin extension for application/octet-stream MIME type #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behavior of adding the .bin extension is allowed--the SAF API does not guarantee anything about file extensions--but some client applications assume that all SAF providers will follow the behavior of AOSP's FileSystemProvider. Fixes: #73 Signed-off-by: Andrew Gunnerson <[email protected]>
|
Test builds:
These are signed with the release key so you can directly upgrade from a release build. |
chenxiaolong
added a commit
that referenced
this pull request
Oct 13, 2024
Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
added a commit
that referenced
this pull request
Oct 13, 2024
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior of adding the
.binextension is allowed--the SAF API does not guarantee anything about file extensions--but some client applications assume that all SAF providers will follow the behavior of AOSP'sFileSystemProvider.Fixes: #73