-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implementing tree-sitter based indentation logic
- previously developed and tested in the sane-indentation package (> 0.9). Refer to atom/language-javascript#594 (comment) By itself this does nothing. The new logic is only used if the language package for the current language contains the necessary configuration (e.g., which scopes to indent on). So this PR goes together with, e.g., FILL-ME-IN in language-javascript.
- Loading branch information
Showing
4 changed files
with
151 additions
and
9 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,132 @@ | ||
|
||
// const log = console.debug; // in dev | ||
const log = () => {}; // in production | ||
|
||
|
||
module.exports = class TreeIndenter { | ||
constructor (languageMode) { | ||
this.languageMode = languageMode; | ||
|
||
this.scopes = atom.config.get('editor.scopes', {scope: this.languageMode.rootScopeDescriptor}); | ||
log('constructor', this.scopes); | ||
} | ||
|
||
/** tree indenter is configured for this language */ | ||
get isConfigured() { | ||
return (!!this.scopes); | ||
} | ||
|
||
// Given a position, walk up the syntax tree, to find the highest level | ||
// node that still starts here. This is to identify the column where this | ||
// node (e.g., an HTML closing tag) ends. | ||
_getHighestSyntaxNodeAtPosition(row, column = null) { | ||
if (column == null) { | ||
// Find the first character on the row that is not whitespace + 1 | ||
column = this.languageMode.buffer.lineForRow(row).search(/\S/) + 1; | ||
} | ||
|
||
let syntaxNode; | ||
if (column >= 0) { | ||
syntaxNode = this.languageMode.getSyntaxNodeAtPosition({row, column}); | ||
while (syntaxNode && syntaxNode.parent | ||
&& syntaxNode.parent.startPosition.row == syntaxNode.startPosition.row | ||
&& syntaxNode.parent.endPosition.row == syntaxNode.startPosition.row | ||
&& syntaxNode.parent.startPosition.column == syntaxNode.startPosition.column | ||
) { | ||
syntaxNode = syntaxNode.parent; | ||
} | ||
return syntaxNode; | ||
} | ||
} | ||
|
||
/** Walk up the tree. Everytime we meet a scope type, check whether we | ||
are coming from the first (resp. last) child. If so, we are opening | ||
(resp. closing) that scope, i.e., do not count it. Otherwise, add 1. | ||
This is the core function. | ||
It might make more sense to reverse the direction of this walk, i.e., | ||
go from root to leaf instead. | ||
*/ | ||
_treeWalk(node, lastScope = null) { | ||
if (node == null || node.parent == null) { | ||
return 0; | ||
} else { | ||
|
||
let increment = 0; | ||
|
||
const notFirstOrLastSibling = | ||
(node.previousSibling != null && node.nextSibling != null); | ||
|
||
const isScope = this.scopes.indent[node.parent.type]; | ||
(notFirstOrLastSibling && isScope && increment++); | ||
|
||
const isScope2 = this.scopes.indentExceptFirst[node.parent.type]; | ||
(!increment && isScope2 && node.previousSibling != null && increment++); | ||
|
||
// check whether the last (lower) indentation happend due to a scope that | ||
// started on the same row and ends directly before this. | ||
// TODO: this currently only works for scopes that have a single-character | ||
// closing delimiter (like statement_blocks, but not HTML, for instance). | ||
if (lastScope && increment > 0 | ||
&& // previous scope was a two-sided scope, reduce if starts on same row | ||
// and ends right before | ||
node.parent.startPosition.row == lastScope.node.startPosition.row | ||
&& node.parent.endIndex <= lastScope.node.endIndex + 1) { | ||
|
||
log('ignoring repeat', node.parent.type, lastScope); | ||
increment = 0; | ||
} | ||
|
||
// Adjusting based on node parent | ||
if (this.languageMode.grammar.precedingRowConditions | ||
&& node.parent.startPosition.row < node.startPosition.row | ||
&& this.languageMode.grammar.precedingRowConditions(node)) { | ||
log(`node adjustment -- previous row condition met`); | ||
increment += 1; | ||
} | ||
|
||
log('treewalk', {node, notFirstOrLastSibling, type: node.parent.type, increment}); | ||
const newLastScope = (isScope || isScope2 ? {node: node.parent} : lastScope); | ||
return this._treeWalk(node.parent, newLastScope) + increment; | ||
} | ||
}; | ||
|
||
|
||
suggestedIndentForBufferRow(row, tabLength, options) { | ||
|
||
this.precedingRowConditions = () => false; | ||
// const precedingRowConditions; // TODO | ||
|
||
// get current indentation for current and preceding line | ||
const precedingRow = Math.max(row - 1, 0); | ||
const precedingLine = this.languageMode.buffer.lineForRow(precedingRow); | ||
const precedingIndentation = this.languageMode.indentLevelForLine(precedingLine, tabLength); | ||
const line = this.languageMode.buffer.lineForRow(row); | ||
const currentIndentation = this.languageMode.indentLevelForLine(line, tabLength); | ||
|
||
const syntaxNode = this._getHighestSyntaxNodeAtPosition(row); | ||
if (!syntaxNode) { | ||
return 0; | ||
} | ||
let indentation = this._treeWalk(syntaxNode); | ||
|
||
// apply current row, single line, type-based rules, e.g., 'else' or 'private:' | ||
this.scopes.types.indent[syntaxNode.type] && indentation++; | ||
this.scopes.types.outdent[syntaxNode.type] && indentation--; | ||
|
||
// Special case for comments | ||
if (syntaxNode.type == 'comment' | ||
&& syntaxNode.startPosition.row < row | ||
&& syntaxNode.endPosition.row > row) { | ||
indentation += 1; | ||
} | ||
|
||
if (options && options.preserveLeadingWhitespace) { | ||
indentation -= currentIndentation; | ||
} | ||
|
||
return indentation; | ||
}; | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters