Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip more tests that depend on behavior of external domains #135

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Skip more tests that depend on behavior of external domains #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions redirects_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ var tooManyRedirectsTests = []struct {
}

func TestTooManyRedirects(t *testing.T) {
// Skip this test because it is failing due to relying on behavior of an
// external domain: https://github.com/chromium/hstspreload/issues/112.
t.SkipNow()

skipIfShort(t)
t.Parallel()

Expand All @@ -58,6 +62,10 @@ func TestTooManyRedirects(t *testing.T) {
}

func TestInsecureRedirect(t *testing.T) {
// Skip this test because it is failing due to relying on behavior of an
// external domain: https://github.com/chromium/hstspreload/issues/112.
t.SkipNow()

skipIfShort(t)
t.Parallel()

Expand All @@ -82,6 +90,10 @@ func TestInsecureRedirect(t *testing.T) {
}

func TestIndirectInsecureRedirect(t *testing.T) {
// Skip this test because it is failing due to relying on behavior of an
// external domain: https://github.com/chromium/hstspreload/issues/112.
t.SkipNow()

skipIfShort(t)
t.Parallel()

Expand Down