Prevent mouse click on input text from clearing text #1159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #646, clicking inside a power-select-multiple input field after typing text clears the text. This proposed fix stops the propagation of the mousedown event if there is text in the input field.
To reproduce:
![screen shot 2018-09-20 at 8 28 03 am](https://user-images.githubusercontent.com/22162337/45829200-39cf8480-bcaf-11e8-8cc1-03550502e9b7.png)
![screen shot 2018-09-20 at 8 28 10 am](https://user-images.githubusercontent.com/22162337/45829208-3cca7500-bcaf-11e8-951e-bffaf53381b2.png)
This issue can be seen on the Ember Power Select multiple-selection page (https://ember-power-select.com/docs/multiple-selection). To reproduce, type some text into the input field (do not press "Enter"). Then click your mouse in the input field, as though you were adjusting the cursor on a Word document. The text vanishes and the dropdown is closed.
Typing in the input
Text disappears on click
Expected behavior:
![screen shot 2018-09-20 at 8 31 36 am](https://user-images.githubusercontent.com/22162337/45829365-9fbc0c00-bcaf-11e8-92c4-19f0e1957982.png)
The cursor can be repositioned by clicking the mouse.
Cursor can be repositioned by clicking in the input