-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fallback replies & implement intentional mentions #2138
Open
nexy7574
wants to merge
9
commits into
cinnyapp:dev
Choose a base branch
from
nexy7574:nexy7574/remove-fallback-replies
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(WIP) the typing on line 301 and 303 needs fixing but apart from that this is mint
…/remove-fallback-replies
Preview: https://2138--pr-cinny.netlify.app |
ajbura
requested changes
Jan 10, 2025
Internal mention also needed to be added in |
..., don't mention the reply author when the reply author is ourself, don't add own user IDs when mentioning intentionally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes fallback replies from messages, and additionally adds
m.mentions
support to Cinny.Fallback replies simply just aren't used anymore, and
m.mentions
works by iterating through the children of the composer to find where tabbed-in mentions have been used, and adds those to the mentions dictionary.This means that cinny no longer accidentally pings anyone who was mentioned in messages that are being replied to.
Fixes #1544
Type of change
Checklist: