refactor

src/index.js

@@ -32,6 +32,16 @@ export default {
 			};
 			return new Response(JSON.stringify(response), { status: errors.length ? 400 : 200 });
 		}
-		return new Response(null, { status: 404 });
+		return new Response(
+			JSON.stringify(
+				{
+					message: 'Not Found',
+					documentation_url: 'https://www.cinotify.cc/docs',
+				},
+				null,
+				2,
+			),
+			{ status: 404 },
+		);
 	},
 };

test/index.spec.js

@@ -2,6 +2,13 @@ import { env, createExecutionContext, waitOnExecutionContext, SELF } from 'cloud
 import { describe, it, expect } from 'vitest';
 import worker from '../src';
 
+const makeRequest = async (request) => {
+	const ctx = createExecutionContext();
+	const response = await worker.fetch(request, env, ctx);
+	await waitOnExecutionContext(ctx);
+	return response;
+};
+
 describe('API', () => {
 	it('errors for missing required parameters', async () => {
 		const request = new Request('http://example.com/api/notify', {
@@ -10,9 +17,7 @@ describe('API', () => {
 				'Content-Type': 'application/json',
 			},
 		});
-		const ctx = createExecutionContext();
-		const response = await worker.fetch(request, env, ctx);
-		await waitOnExecutionContext(ctx);
+		const response = await makeRequest(request);
 		expect(await response.json()).toEqual({
 			errors: ["missing required parameter 'subject'", "missing required parameter 'to'"],
 		});
@@ -29,10 +34,13 @@ describe('API', () => {
 				subject: 'hello world',
 			}),
 		});
-		const ctx = createExecutionContext();
-		const response = await worker.fetch(request, env, ctx);
-		await waitOnExecutionContext(ctx);
+		const response = await makeRequest(request);
 		expect(await response.json()).toEqual(expect.not.objectContaining({ errors: [] }));
 		expect(response.status).toEqual(200);
 	});
+	it('404s for undefined routes', async () => {
+		const request = new Request('http://example.com/undefined-route');
+		const response = await makeRequest(request);
+		expect(response.status).toEqual(404);
+	});
 });