Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add abort and mailce scenarios to security doc #15

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

rishkwal
Copy link
Contributor

No description provided.

Copy link
Contributor

@KnowWhoami KnowWhoami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.
I think , we should also add links for IT's in the respective sections.
There , how the fees balances work are mentioned in those IT's as done in citadel-tech/coinswap#355

Comment on lines +19 to +22
This is the situation where a Maker prematurely drops connections after doing initial protocol handshake.
This should not necessarily disrupt the round, the Taker will try to find more makers in his address book to carry on as usual.
The Taker will mark this Maker as "bad" and will not swap this maker again.
In case the Taker doesn't find any more makers, it will abort the swap and reclaim his funds via the contract transaction and so will the other makers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we have three scenarios for case 2 -> and I observed that Taker would scout for a new maker to continue with ongoing coinswap only when Taker has not spend its funding txes yet.
If Taker broadcasted its funding txes and Maker does these cheats -> then taker simply broadcast its contract tx.
SO IMO, it would be better to mention about it.

If the Taker doesn't come back within timeout, the Makers broadcasts the contract transactions and reclaims their funds via timelock.
The Taker after coming live again will see unfinished coinswaps in his wallet. He can reclaim his funds via broadcasting his contract transactions and claiming via timelock.

### 2. Maker Drops Before Setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess , it would be better to mention all possible cases under this scenario , as similarly done for Maker drop After Setup.

Comment on lines 5 to -7

A denial of service (DoS) attack is a type of attack where a malicious actor floods the network with a large number of requests, causing the network to become overwhelmed and unresponsive. In the context of Coinswap, a DoS attack could disrupt the swap process and prevent legitimate users from participating in the network.
## Aborts

## Distributed Denial of Service (DDoS) attacks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason for not mentioning about DOS attack?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defending against DoS would be a part of the extended infrastructure(setting up reverse proxies, etc) and not a part of the protocol itself.

@rishkwal rishkwal merged commit 764a371 into citadel-tech:main Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants