Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique DNS key #349

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Use unique DNS key #349

merged 4 commits into from
Jan 2, 2025

Conversation

mojoX911
Copy link

@mojoX911 mojoX911 commented Dec 26, 2024

Fixes #348

Made on top of #345

Only review from commit 4fb34ee

@mojoX911 mojoX911 requested a review from Shourya742 December 26, 2024 17:31
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 20 lines in your changes missing coverage. Please review.

Project coverage is 72.92%. Comparing base (81618fe) to head (0c42b56).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/market/directory.rs 45.71% 19 Missing ⚠️
src/market/rpc/server.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   72.97%   72.92%   -0.05%     
==========================================
  Files          33       33              
  Lines        4107     4118      +11     
==========================================
+ Hits         2997     3003       +6     
- Misses       1110     1115       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wukong247 Wukong247 self-requested a review December 28, 2024 14:56
@Shourya742 Shourya742 force-pushed the dns-update branch 3 times, most recently from 1764cf9 to f1ced34 Compare January 2, 2025 13:25
@mojoX911 mojoX911 merged commit 33f049e into citadel-tech:master Jan 2, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make DNS entry key unique
2 participants