Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme update #371

Merged
merged 5 commits into from
Jan 8, 2025
Merged

readme update #371

merged 5 commits into from
Jan 8, 2025

Conversation

mojoX911
Copy link

@mojoX911 mojoX911 commented Jan 8, 2025

update correct link and remove dev book.

Copy link
Collaborator

@KnowWhoami KnowWhoami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack...
Mentioned below links are broken which needs to be updated and then it's good to go.

README.md Show resolved Hide resolved
@KnowWhoami
Copy link
Collaborator

There are various places mentioning about Signet and links for Signet faucet -> Instead it needs to be replaced with Testnet4.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@8659da9). Learn more about missing BASE report.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #371   +/-   ##
=========================================
  Coverage          ?   70.30%           
=========================================
  Files             ?       34           
  Lines             ?     4146           
  Branches          ?        0           
=========================================
  Hits              ?     2915           
  Misses            ?     1231           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojoX911 mojoX911 merged commit 1a3d987 into citadel-tech:master Jan 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants