feat: implement Clone for MemoryDB #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/citahub/cita-trie/blob/0de727ce4835810dd8d5e6a1ef28d73ae2e3f4da/src/db.rs#L48 Because using Arc wrap map, so we prefer use default clone. If you need deep clone you can add a method to achieve it. Ty for your pr. |
|
Given that a deep clone can only be made with access to the private member variables, is it okay to add a deep clone method to the public API? If so, what would you like it to be called @Pencil-Yao? |
|
Achieve deep copy would not make the |
|
New PR created for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs a deep clone, creating a separate storage