-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outdated: Issue/1175/improve open api final 2 #1224
base: main
Are you sure you want to change the base?
Conversation
31731e3
to
7b85d6a
Compare
af4b223
to
18ae70b
Compare
pr: #1224 `citrus-openapi` module.
pr: #1224 `citrus-openapi` module.
pr: #1224 `citrus-openapi` module.
pr: #1224 `citrus-spring` module.
pr: #1224 `citrus-spring` module.
pr: #1224 `citrus-http` module.
pr: #1224 `citrus-http` module.
pr: #1224 `citrus-test-api-core` module.
pr: #1224 `citrus-openapi` module.
pr: #1224 `citrus-http` module.
pr: #1224 `citrus-jms` module.
pr: #1224 `citrus-rmi` module.
pr: #1224 `citrus-test-api-core` module.
pr: #1224 `citrus-test-api-generator-core` module.
pr: #1224 `citrus-test-api-generator-maven-plugin` module.
pr: #1224 `citrus-test-api-spring` module.
pr: #1224 `citrus-validation` module and sub-modules.
Use: - generated-(test)-sources/openapi/src/main/java - generated-(test)-sources/openapi/src/main/resources - generated-(test)-sources/openapi/src/main/resources/META-INF (as default for spring artefacts)
- depending on configuration server urls are not really required - fix expected code gen for generated api test
…ges to name the path of origin
cd40314
to
5a036af
Compare
I tried to avoid breaking the existing OpenAPI feature, but there are some potentially breaking changes:
Additionally, there's a new feature in citrus-simulator that integrates with the OpenAPI feature, enabling scenario generation from OpenAPI specifications. I implemented a huge amount of tests for all this and we have beta-tested the new feature with several inhouse projects. So I am quite confident, that the current state has the required maturity to be moved to main. I spend a couple of hours in the last days for documentation. I am sure, that this would be a good starting point although I am also sure, that Timon has a couple of suggestions for the documentation. If you have any questions or see the need for further documentation, just let me know. |
After discussion with Timon I am rewriting the PR. I will provide smaller PR with specific meanings. So stay tuned before reviewing. |
I took the time to perform a soft reset and carefully organized everything into 21 meaningful commits as the OpenAPI feature evolved. I’m quite confident that the overall result is solid, but individual commits might have minor issues that only resolve fully when everything is merged together. The first MR is: There are 4 further branches named We will have to merge them one by one as review proceeds. The last one contains all changes. So we might as well go with that one and review the code on commit level within one MR. It is up to you. |
This is the final PR for the new OpenAPI feature.
I apologize for the large size of this PR. It includes the following major changes:
org.citrusframework.openapi.generator.GeneratedRestApiIT
gives an overview on how to use the generated REST APIorg.citrusframework.openapi.generator.GeneratedSoapApiIT
same for SOAP although only very little, yetsee org.citrusframework.http.message.HttpQueryParamHeaderValidator
for details