Enhance readme #30
Enhance readme #30
Conversation
SaitTalhaNisanci
force-pushed
the
enhance/README
branch
from
71029a7 to
50d459a
Compare
|
|
||
| ## Introduction | ||
|
|
||
| This repository contains the source code for docker images that are used in [citus testing](https://github.com/citusdata/citus/blob/master/.circleci/config.yml). The images are pushed to [docker hub](https://hub.docker.com/u/citus). There is no hooking logic between this repository and the docker hub account. It is used purely for the storage of our images source code. |
There was a problem hiding this comment.
Can we make an issue to track a task to automate the image creation from a CI job? Running upgrades on developer machines have proven to be troublesome, as we had to create a new docker hub account due to access restrictions.
| - The script (`install-and-test-ext`) takes the target name as an argument, and the following command is used to run the test: | ||
| While building the image: | ||
|
|
||
| * Install postgres major which is taken as an argument `PG_MAJOR`. |
There was a problem hiding this comment.
most images would and should be taken from the original postgres releases, I think this line does not reflect that.
There was a problem hiding this comment.
Well if we install pg12 from the postgres base image, when we try to install libcurl, it installs libcurl4 and citus does not want libcurl4 but libcurl3. We can add libcurl3 package source to our apt/source.list but in the future another package can cause a problem too. And in the extbuilder image we also dont install from pg base image as we have multiple pg majors. So installing the same way as extbuilder seemed okay to me, what do you think?
|
|
||
| Because of the specific logic that we have to run tests faster, we have a docker image `debbuilder` that generates a debian package for `postgresql-server-dev-{pg-major}`. The generated package is in the built docker image, specifically in `{container-name}/home/circleci/debs`. The package is pushed to [the-process](https://packagecloud.io/citus-bot/the-process). This package place is added to apt source list and pinned with with the highest priority so that it is chosen over the standard `postgresql-server-dev-{pg-major}` package. | ||
|
|
||
| The installation of postgres packages is at the time of building the image to reduce testing time. However this means that once the image is built the postgres version is fixed. You will need to rebuild the image if you want to upgrade the image, upgrading the image for a minor version is easier compared to upgrading a major version. |
There was a problem hiding this comment.
shouldn't changing the major version for most containers entail to rebuild with a different PG_MAJOR build arg? I think only for pg upgrade tests, where we need multiple postgres versions, and the extbuilder, where we also need multiple postgres versions, the build is slightly harder as we need to change some of the scripts.
There was a problem hiding this comment.
For many images yes. What should be done is explained for each image, is there something that you think is redundant or can be simplified?
README.md
Outdated
|
|
||
| ### 1.1. How circleci uses our images in testing | ||
|
|
||
| Our [dockerhub account](https://hub.docker.com/u/citus) has all the images here expect the `debbuilder`. When a change is committed, circleci: |
There was a problem hiding this comment.
| Our [dockerhub account](https://hub.docker.com/u/citus) has all the images here expect the `debbuilder`. When a change is committed, circleci: | |
| Our [dockerhub account](https://hub.docker.com/u/citus) has all the images here except the `debbuilder`. When a change is committed, circleci: |
SaitTalhaNisanci
force-pushed
the
enhance/README
branch
from
50d459a to
a1ce932
Compare
No description provided.