-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update moped_workgroup to reflect reorganization #1515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,3 @@ | |||
-- Updating moped_workgroup table will be up only. If we need to revert, we will need do it manually or | |||
-- update with a future migration. | |||
SELECT 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this is what I should've done on my last update to the moped_fund_status
table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like what you've got, Mateo. It reverts back to the previous DB state cleanly ✅ 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 - i like the down migration for the funding descriptions too. i've been omitting down migrations for these reorg changes since they update records in other tables and would take some heavier lifting to go back.
SET | ||
workgroup_id = (SELECT id FROM new_workgroup_row) | ||
WHERE | ||
workgroup_id IN (SELECT ids FROM user_todos); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty slick way of doing this—nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! congrats to the urban sidewalks division
moped_workgroup( | ||
order_by: { workgroup_name: asc } | ||
where: { is_deleted: { _eq: false } } | ||
) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! i did a quick scan of instances of moped_workgroup
in the editor and couldn't find anything else that would be affected by this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for checking! 🙏
Associated issues
Closes cityofaustin/atd-data-tech#19854
This PR updates workgroups with Sidewalks and Urban Trails and updates any users with Sidewalks or Urban Trails as their workgroup to fall under the new workgroup.
Testing
URL to test:
Local
Steps to test:
moped_workgroup
table and see that:Moped Test Admin
in our vault or your own account) so you can see the staff form in later steps and then go to the Staff tabSidewalks
and you should only see users withSidewalks and Urban Trails
workgroupsSidewalks and Urban Trails
is available to selectShip list
[ ] Product manager added to QA test script if applicable