feat: Add categories and short name to CRD #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -162,6 +162,7 @@ type KamajiControlPlaneStatus struct { | |||
|
|
|||
| //+kubebuilder:object:root=true | |||
| //+kubebuilder:subresource:status | |||
| //+kubebuilder:resource:categories=cluster-api;kamaji,shortName=kjcp | |||
There was a problem hiding this comment.
Suggested change
| //+kubebuilder:resource:categories=cluster-api;kamaji,shortName=kjcp | |
| //+kubebuilder:resource:categories=cluster-api;kamaji,shortName=ktcp |
Kamaji
Tenant
Control
Plane
Any suggestion here is really valuable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add categories to KamajiControlPlane so that they can be inspected together with other Cluster API resources and TCPs.
Also add a short name. I chose
kjcpbecausekcpis already taken. I'm open to change it though