Accept version strings with and without a 'v' prefix #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Hros <[email protected]>
chess-knight
force-pushed
the
fix/tolerate_version_prefix
branch
from
fb0647e to
c5b6448
Compare
IMO the opposite is the correct way, i.e. v1.30.1 |
prometherion
approved these changes
Jun 13, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ClusterClasses,
Versionis propagated fromcluster.Spec.Topologyinto thekamajicontrolplane.Specwith a "v" prefix and then Kamaji complains about the wrong version format. See CAPI defaulting webhook https://github.com/kubernetes-sigs/cluster-api/blob/main/internal/webhooks/cluster.go#L100