Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests #130

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Add e2e tests #130

merged 2 commits into from
Oct 21, 2024

Conversation

dineshba
Copy link
Contributor

@dineshba dineshba commented Oct 12, 2024

Create new e2e github actions workflow and resolves #15

Test coverage:

  • Running cluster-api-control-plane-provider-kamaji and validate no crashes
  • Creating target cluster using cluster-api-control-plane-provider-kamaji and kubevirt infra provider
  • Validate the cluster, kamajicontrolplane CR's readiness
  • Validate the worker CRs like Machine, Kubevirt-pod readiness
  • Fetch the kubeconfig of target cluster and install calico CNI
  • Validate the readiness of target cluster node

Successfully run: https://github.com/dineshba/cluster-api-control-plane-provider-kamaji/actions/runs/11303188257/job/31439998988
Screenshot:
image

@dineshba dineshba marked this pull request as ready for review October 12, 2024 14:56
@dineshba
Copy link
Contributor Author

Hi @prometherion, please help in review and provide your inputs. It has the basic validations as described in the PR description

@prometherion
Copy link
Member

I'd say this is a good starting point, thanks for it.

I would avoid installing the Kamaji Control Plane provider using the already published manifests, but rather, I'd use the ones available in the checked out, as well as load the container image to the kind instance: if you prefer, I can take care of these actions with a subsequent PR.

@dineshba
Copy link
Contributor Author

I totally agree with the PR based manifests and images. I can either add to this PR or create new PR. Please share your inputs

@prometherion
Copy link
Member

I would prefer having everything in one single PR, thanks!

@dineshba
Copy link
Contributor Author

Hi @prometherion, Please review the latest commit fb6d8ed

What is done:

  • build docker image
  • Loaded that docker image into Kind
  • Changed the manifests to point to new docker image
  • Configure clusterctl to get config files from local instead of released artifacts
  • Validated if the right image is used or not

@prometherion
Copy link
Member

@dineshba we can ignore the golangci-lint stage, I'll fix it later since I merged a non linted PR, my bad. Thanks for your contribution! 🙏🏻

@prometherion prometherion merged commit 72c5863 into clastix:master Oct 21, 2024
3 of 4 checks passed
@prometherion prometherion added this to the v0.12.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e coverage
2 participants