-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orleans.Contrib.UniversalSilo 0.9.1 #25286
Conversation
You can review the change introduced to the full definition at ClearlyDefined. |
@AE49 I'm not finding any license info. NONE? |
@capfei , I'm not sure I understand what the feedback requested is: The link is here where the MIT license is provided (in the PR description): https://github.com/johnazariah/orleans-contrib-universalsilo/blob/main/LICENSE It is not NONE, the PR marks it as MIT. |
@xinyi-joffre The reason I'm suggesting NONE is the NuGet package does not contain any license information nor does it point to this repo. |
I tried looking at other versions of this repo and couldn't find any that linked to the repo listed in the PR comment. If I missed it, please link to the version of this NuGet package that contains the link. |
I don't own the nuget package, but the owner for the nuget package and the github repo is the same, and the nuget namespace matches. We're updating the license for the latest version of the package, but the prior versions of this package are also listed as MIT already in ClearlyDefined. This is not a new package. https://www.nuget.org/packages/Orleans.Contrib.UniversalSilo/ => owned by johnazariah https://github.com/johnazariah/orleans-contrib-universalsilo => owned by johnasariah |
@ariel11 Can I get your opinion? |
@capfei I agree with NONE based on our curation guidelines. This version of the NuGet package does not have a license nor is there a clear link to the GitHub repo. If the author wants to apply MIT to all versions, seems they should add a link to the GitHub repo? |
@capfei and @AE49 - I think in the past if we could make a solid connection between the repo and the package we went with the repo's license. Ideally, we'd see an actual package metadata file like a nuspec in the repo. The names between the package owner and this repo do match. Thoughts on opening an Issue and asking if the repo's MIT license applies to this NuGet package? https://www.nuget.org/packages/Orleans.Contrib.UniversalSilo/ |
Opened an issue asking about the license for the NuGet: johnazariah/orleans-contrib-universalsilo#70 |
I'd be delighted to help with this. Is there an accepted way of adding this metadata while packing? Should I do something like rename the
or should I doing something else with the Sorry for the n00b question |
@johnazariah - thank you! For this license database (ClearlyDefined), we are trying to validate the license for these (https://www.nuget.org/packages/Orleans.Contrib.UniversalSilo/) NuGet packages because we aren't seeing any license information in the package. We usually see the license information on the nuspec file. Did you intend for these NuGet packages to be MIT like the source code repo? If that's the case, with author clarification, we can put "MIT" in this license database. Thank you! |
Yes MIT would be fine. And I appreciate the help!
…On Thu, 5 Oct 2023, 05:11 Ariel, ***@***.***> wrote:
@johnazariah <https://github.com/johnazariah> - thank you! For this
license database (ClearlyDefined), we are trying to validate the license
for these (https://www.nuget.org/packages/Orleans.Contrib.UniversalSilo/)
NuGet packages because we aren't seeing any license information in the
package. We usually see the license information on the nuspec file
<https://learn.microsoft.com/en-us/nuget/reference/nuspec>. Did you
intend for these NuGet packages to be MIT like the source code repo? If
that's the case, with author clarification, we can put "MIT" in this
license database. Thank you!
—
Reply to this email directly, view it on GitHub
<#25286 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGKWZY3IM4A4YCSY53ID73X5WYFBAVCNFSM6AAAAAA4H3ZT42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBXGQ4DINZUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Type: Missing
Summary:
Orleans.Contrib.UniversalSilo 0.9.1
Details:
Add MIT License
Resolution:
License Url:
https://github.com/johnazariah/orleans-contrib-universalsilo/blob/main/LICENSE
Description:
The LICENSE file is provided in the GitHub repository for this package.
Pull request generated by Microsoft tooling.
Affected definitions: