use fallback for magic requires when there's no middlware #559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a new defcustom
cljr-magic-requires-fallback
defcustom, so we can generate require expressions (fromcljr-magic-require-namespaces
) even if middleware is not available for some reason (e.g. when using babashka)also, I updated
cljr-magic-require-namespaces
with more idiomatic aliases from The Clojure Style Guide.The commits are consistent with our contribution guidelines
You've added tests (if possible) to cover your change(s)
The new code is not generating byte compile warnings (run
cask exec emacs -batch -Q -L . -eval "(progn (setq byte-compile-error-on-warn t) (batch-byte-compile))" clj-refactor.el
)All tests are passing (run
./run-tests.sh
)You've updated the changelog (if adding/changing user-visible functionality)
You've updated the readme (if adding/changing user-visible functionality)