Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter out unsupported policies #600

Merged
merged 3 commits into from
Nov 24, 2023
Merged

filter out unsupported policies #600

merged 3 commits into from
Nov 24, 2023

Conversation

kickster97
Copy link
Member

WHAT is this pull request doing?

Adds an array SUPPORTED_POLICIES and filters on it Policy's merge_definitions

HOW can this pull request be tested?

try and add an unsupported policy, eg. HA policy, and view the effective policy definition on the queue

@kickster97 kickster97 marked this pull request as draft November 22, 2023 14:45
@kickster97 kickster97 marked this pull request as ready for review November 22, 2023 15:21
src/lavinmq/policy.cr Outdated Show resolved Hide resolved
Copy link
Member

@spuun spuun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A spec would be nice!

@kickster97
Copy link
Member Author

A spec would be nice!

@spuun added a spec :)

@kickster97 kickster97 requested a review from spuun November 23, 2023 14:37
@kickster97 kickster97 merged commit f132fb9 into main Nov 24, 2023
23 of 26 checks passed
@kickster97 kickster97 deleted the filter_policies branch November 24, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants