send connection_information to amqp-client #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kickster97
force-pushed
the
send_client_args_to_amqp_client
branch
from
a7174d4 to
a6878da
Compare
kickster97
force-pushed
the
send_client_args_to_amqp_client
branch
from
7c6c855 to
da52452
Compare
kickster97
force-pushed
the
send_client_args_to_amqp_client
branch
2 times, most recently
from
1dd3c6c to
41ec0b4
Compare
kickster97
force-pushed
the
send_client_args_to_amqp_client
branch
from
41ec0b4 to
956d684
Compare
kickster97
force-pushed
the
send_client_args_to_amqp_client
branch
from
e31f285 to
89dd877
Compare
viktorerlingsson
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
One small suggestion, otherwise looks good to me!
Gonna be fun merging with this... 😅
Co-authored-by: Viktor Erlingsson <[email protected]>
viktorerlingsson
added a commit
that referenced
this pull request
Sep 20, 2024
* send client_information to amqp-client * refactor start_link --------- Co-authored-by: Viktor Erlingsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Cannot be merged until #39 is released.
With this PR we send in connection information
product: "LavinMQ", platform: "Crystal", product_version: LavinMQ::VERSION, platform_version: Crystal::VERSIONto amqp-client, in order for us to be able to have more accurate connection information displayed for federation connections.
Also: does a little refactor on
start_link, to dry out some of the code repeated in bothQueueLinkandExchangeLinkHOW can this pull request be tested?
pull down the amqp-client PR and create an override shards file, then start a federation to another broker and look at the connection information in the UI.