Bugfix: federation queue link, dont transfer messages unless consumer exists #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorerlingsson
force-pushed
the
bugfix_federation_dont_transfer_unless_consumer
branch
from
0d9e1e4 to
8421880
Compare
This comment was marked as resolved.
This comment was marked as resolved.
viktorerlingsson
force-pushed
the
bugfix_federation_dont_transfer_unless_consumer
branch
from
927945b to
84ae73e
Compare
viktorerlingsson
force-pushed
the
bugfix_federation_dont_transfer_unless_consumer
branch
from
fb24e65 to
335c1c6
Compare
viktorerlingsson
requested review from
kickster97,
carlhoerberg and
spuun
and removed request for
kickster97 and
carlhoerberg
|
Just a little remark that came to my mind: By removing the local If I can manage to break out |
…nless there is a consumer
…inks. refactoring
viktorerlingsson
force-pushed
the
bugfix_federation_dont_transfer_unless_consumer
branch
from
dfe2646 to
18f25bd
Compare
viktorerlingsson
deleted the
bugfix_federation_dont_transfer_unless_consumer
branch
@spuun, We should remember this now that we have the PR for the abstraction out :) |
viktorerlingsson
added a commit
that referenced
this pull request
Sep 20, 2024
… exists (#637) Stops federation queue links from transferring messages unless there is an active consumer on the downstream. federate now publishes directly to vhost instead of using a client. This allows us to use the immediate flag to make sure we don't federate messages unless there is a consumer on the downstream queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Stops federation queue links from transferring messages unless there is an active consumer on the downstream.
federatenow publishes directly to vhost instead of using a client. This allows us to use the immediate flag to make sure we don't federate messages unless there is a consumer on the downstream queue.HOW can this pull request be tested?
Run the specs