Nilguard delayed arguments #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
for some reason the other pr would not track my commits... maybe something is fishy with the CLA assistant :( |
kickster97
force-pushed
the
nilguard_delayed_arguments
branch
2 times, most recently
from
80445c1 to
d5638aa
Compare
viktorerlingsson
pushed a commit
that referenced
this pull request
Sep 20, 2024
* add nilguard for matching x-delayed-type argument * add specs for delayed message exchanges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
If you try and redeclare a delayed exchange with no
x-delayed-typeargument, it will crash inexchanges.cr:match?(frame)This pull request adds a nilguard for the argument check, and as a result, the
matchmethod will return false if there is nox-delayed-typeargument and send aPreconditioned Failed: Existing exchange 'my_delayed_exchange' declared with other argumentsinstead of crashing.HOW can this pull request be tested?
Declare a delayed exchange "my-delayed-exchange", with argument
{ "x-delayed-type" => "direct" }, then try and declare the exchange again, but with nox-delayed-typeargument.